TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dm array: fix unreleased btree blocks on closing a faulty array cursor

Browse Source 
[ Upstream commit 626f128ee9 ]

The cached block pointer in dm_array_cursor might be NULL if it reaches
an unreadable array block, or the array is empty. Therefore,
dm_array_cursor_end() should call dm_btree_cursor_end() unconditionally,
to prevent leaving unreleased btree blocks.

This fix can be verified using the "array_cursor/iterate/empty" test
in dm-unit:
  dm-unit run /pdata/array_cursor/iterate/empty --kernel-dir <KERNEL_DIR>

Signed-off-by: Ming-Hung Tsai <mtsai@redhat.com>
Fixes: fdd1315aa5 ("dm array: introduce cursor api")
Reviewed-by: Joe Thornber <thornber@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ming-Hung Tsai
2024-12-05 19:41:52 +08:00
committed by Greg Kroah-Hartman
parent 6002bec535
commit 14f0e64c2f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/md/persistent-data/dm-array.c
+3 -3
View File
@@ -960,10 +960,10 @@ EXPORT_SYMBOL_GPL(dm_array_cursor_begin);
void dm_array_cursor_end(struct dm_array_cursor *c) void dm_array_cursor_end(struct dm_array_cursor *c)
{ {
if (c->block) { if (c->block)
unlock_ablock(c->info, c->block); unlock_ablock(c->info, c->block);
dm_btree_cursor_end(&c->cursor);
} dm_btree_cursor_end(&c->cursor);
} }
EXPORT_SYMBOL_GPL(dm_array_cursor_end); EXPORT_SYMBOL_GPL(dm_array_cursor_end);