USB: mcs7830: return negative if auto negotiate fails
The original code returns 0 on success and 1 on failure. In fact, at this point, "ret" is already either zero or a negative error code so we can just return it directly. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
fdac1e0697
commit
0e214ad815
@@ -355,7 +355,7 @@ static int mcs7830_set_autoneg(struct usbnet *dev, int ptrUserPhyMode)
|
|||||||
if (!ret)
|
if (!ret)
|
||||||
ret = mcs7830_write_phy(dev, MII_BMCR,
|
ret = mcs7830_write_phy(dev, MII_BMCR,
|
||||||
BMCR_ANENABLE | BMCR_ANRESTART );
|
BMCR_ANENABLE | BMCR_ANRESTART );
|
||||||
return ret < 0 ? : 0;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user