TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: dwc3: gadget: issue ENDTRANSFER conditional on resource_index

Browse Source 
Because of recent changes to transfer handling on
DWC3, we will not get XferComplete unless we
completely fill up our TRB ring. This means that we
might get a Reset or Disconnect without getting a
XferComplete first.

In order to correctly release our allocated Transfer
Resource, we must issue ENDTRANSFER command whenever
dep->resource_index is valid.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
This commit is contained in:
Felipe Balbi
2016-06-21 10:32:02 +03:00
parent 328082376a
commit 0e146028ee
1 changed files with 5 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/usb/dwc3/gadget.c
+5 -15
View File
@@ -607,24 +607,14 @@ static void dwc3_stop_active_transfer(struct dwc3 *dwc, u32 epnum, bool force);
static void dwc3_remove_requests(struct dwc3 *dwc, struct dwc3_ep *dep) static void dwc3_remove_requests(struct dwc3 *dwc, struct dwc3_ep *dep)
{ {
struct dwc3_request *req; struct dwc3_request *req;
struct dwc3_trb *current_trb;
unsigned transfer_in_flight;
if (dep->number > 1) dwc3_stop_active_transfer(dwc, dep->number, true);
current_trb = &dep->trb_pool[dep->trb_enqueue];
else
current_trb = &dwc->ep0_trb[dep->trb_enqueue];
transfer_in_flight = current_trb->ctrl & DWC3_TRB_CTRL_HWO;
if (transfer_in_flight && !list_empty(&dep->started_list)) { /* - giveback all requests to gadget driver */
dwc3_stop_active_transfer(dwc, dep->number, true); while (!list_empty(&dep->started_list)) {
req = next_request(&dep->started_list);
/* - giveback all requests to gadget driver */ dwc3_gadget_giveback(dep, req, -ESHUTDOWN);
while (!list_empty(&dep->started_list)) {
req = next_request(&dep->started_list);
dwc3_gadget_giveback(dep, req, -ESHUTDOWN);
}
} }
while (!list_empty(&dep->pending_list)) { while (!list_empty(&dep->pending_list)) {