TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

s390/dasd: use correct number of retries for ERP requests

Browse Source 
[ Upstream commit acea28a6b7 ]

If a DASD request fails an error recovery procedure (ERP) request might
be built as a copy of the original request to do error recovery.

The ERP request gets a number of retries assigned.
This number is always 256 no matter what other value might have been set
for the original request. This is not what is expected when a user
specifies a certain amount of retries for the device via sysfs.

Correctly use the number of retries of the original request for ERP
requests.

Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com>
Link: https://lore.kernel.org/r/20230721193647.3889634-3-sth@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Stefan Haberland
2023-07-21 21:36:45 +02:00
committed by Greg Kroah-Hartman
parent a5fd143673
commit 0c96df6913
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/s390/block/dasd_3990_erp.c
+1 -1
View File
@@ -2436,7 +2436,7 @@ static struct dasd_ccw_req *dasd_3990_erp_add_erp(struct dasd_ccw_req *cqr)
erp->block = cqr->block; erp->block = cqr->block;
erp->magic = cqr->magic; erp->magic = cqr->magic;
erp->expires = cqr->expires; erp->expires = cqr->expires;
erp->retries = 256; erp->retries = device->default_retries;
erp->buildclk = get_tod_clock(); erp->buildclk = get_tod_clock();
erp->status = DASD_CQR_FILLED; erp->status = DASD_CQR_FILLED;