TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

More exported clocks for rk3128 peripherals, conversion to kmemduo_array

Browse Source 
for clock controllers and both rk3128 and rk3188 drop the CLK_NR_CLKS
 from their dt-binding header, where it does not belong.
 -----BEGIN PGP SIGNATURE-----
 
 iQFEBAABCAAuFiEE7v+35S2Q1vLNA3Lx86Z5yZzRHYEFAmaG9OkQHGhlaWtvQHNu
 dGVjaC5kZQAKCRDzpnnJnNEdgRK1CACGI6t5JF2iMisJq0dpwA9HhREvu9NnUwtu
 v/AteJyo9rl/3ox55U3srlaTM4AP2+F4e7ZsVrjwVXKcGg4ir6PEkxTJ3sigOcAK
 7FSHbcOcDfsRk46Yu/ZhvRQEuVJpuL5F/M36Vdmt2/wVUooCSWVc6RJPtnsdJpx7
 rvGY7/fnc0b5uRtZq8mhvbIF11uj80kokKNENWWJ11uymQp4igtEGxYnYMlb/5CO
 bXqo98+8ce6cz50piRuFB6NzWhl7BlnSTf5RiMATvi0zgu2I7BVNw5yjvfHVkv6L
 XTEF/4B+gxpDOcn65Z7YlD2lhnX5uNvh4kjCsmYxmhkG3L5j+OtT
 =TXXc
 -----END PGP SIGNATURE-----

Merge tag 'v6.11-rockchip-clk1' of git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip into clk-rockchip

Pull Rockchip clk driver updates from Heiko Stuebner:

 - Export more clocks for Rockchip rk3128 peripherals
 - Convert Rockchip clk drivers to use kmemdup_array()
 - Drop CLK_NR_CLKS from Rockchip rk3128 and rk3188 binding headers

* tag 'v6.11-rockchip-clk1' of git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip:
  dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS
  clk: rockchip: rk3188: Drop CLK_NR_CLKS usage
  clk: rockchip: Switch to use kmemdup_array()
  clk: rockchip: rk3128: Add HCLK_SFC
  dt-bindings: clock: rk3128: Add HCLK_SFC
  dt-bindings: clock: rk3128: Drop CLK_NR_CLKS
  clk: rockchip: rk3128: Drop CLK_NR_CLKS usage
  clk: rockchip: rk3128: Add hclk_vio_h2p to critical clocks
  clk: rockchip: rk3128: Export PCLK_MIPIPHY
  dt-bindings: clock: rk3128: Add PCLK_MIPIPHY
This commit is contained in:
Stephen Boyd 2024-07-08 11:34:41 -07:00
commit 04718d1e4d
6 changed files with 41 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/clk/rockchip/clk-cpu.c
View File

@ -369,9 +369,8 @@ struct clk *rockchip_clk_register_cpuclk(const char *name,
if (nrates > 0) {
cpuclk->rate_count = nrates;
cpuclk->rate_table = kmemdup(rates,
sizeof(*rates) * nrates,
GFP_KERNEL);
cpuclk->rate_table = kmemdup_array(rates, nrates, sizeof(*rates),
GFP_KERNEL);
if (!cpuclk->rate_table) {
ret = -ENOMEM;
goto unregister_notifier;

8
drivers/clk/rockchip/clk-pll.c
View File

@ -1136,10 +1136,10 @@ struct clk *rockchip_clk_register_pll(struct rockchip_clk_provider *ctx,
len++;
pll->rate_count = len;
pll->rate_table = kmemdup(rate_table,
pll->rate_count *
sizeof(struct rockchip_pll_rate_table),
GFP_KERNEL);
pll->rate_table = kmemdup_array(rate_table,
pll->rate_count,
sizeof(*pll->rate_table),
GFP_KERNEL);
WARN(!pll->rate_table,
"%s: could not allocate rate table for %s\n",
__func__, name);

24
drivers/clk/rockchip/clk-rk3128.c
View File

@ -526,7 +526,7 @@ static struct rockchip_clk_branch common_clk_branches[] __initdata = {
GATE(PCLK_ACODEC, "pclk_acodec", "pclk_cpu", 0, RK2928_CLKGATE_CON(5), 14, GFLAGS),
GATE(0, "pclk_ddrupctl", "pclk_cpu", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(5), 7, GFLAGS),
GATE(0, "pclk_grf", "pclk_cpu", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(5), 4, GFLAGS),
GATE(0, "pclk_mipiphy", "pclk_cpu", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(5), 0, GFLAGS),
GATE(PCLK_MIPIPHY, "pclk_mipiphy", "pclk_cpu", 0, RK2928_CLKGATE_CON(5), 0, GFLAGS),
GATE(0, "pclk_pmu", "pclk_pmu_pre", 0, RK2928_CLKGATE_CON(9), 2, GFLAGS),
GATE(0, "pclk_pmu_niu", "pclk_pmu_pre", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(9), 3, GFLAGS),
@ -553,6 +553,7 @@ static struct rockchip_clk_branch rk3128_clk_branches[] __initdata = {
RK2928_CLKSEL_CON(11), 14, 2, MFLAGS, 8, 5, DFLAGS,
RK2928_CLKGATE_CON(3), 15, GFLAGS),
GATE(HCLK_SFC, "hclk_sfc", "hclk_peri", 0, RK2928_CLKGATE_CON(7), 1, GFLAGS),
GATE(HCLK_GPS, "hclk_gps", "aclk_peri", 0, RK2928_CLKGATE_CON(3), 14, GFLAGS),
GATE(PCLK_HDMI, "pclk_hdmi", "pclk_cpu", 0, RK2928_CLKGATE_CON(3), 8, GFLAGS),
};
@ -563,23 +564,28 @@ static const char *const rk3128_critical_clocks[] __initconst = {
"pclk_cpu",
"aclk_peri",
"hclk_peri",
"hclk_vio_h2p",
"pclk_peri",
"pclk_pmu",
"sclk_timer5",
};
static struct rockchip_clk_provider *__init rk3128_common_clk_init(struct device_node *np)
static struct rockchip_clk_provider *__init rk3128_common_clk_init(struct device_node *np,
unsigned long soc_nr_clks)
{
struct rockchip_clk_provider *ctx;
unsigned long common_nr_clks;
void __iomem *reg_base;
common_nr_clks = rockchip_clk_find_max_clk_id(common_clk_branches,
ARRAY_SIZE(common_clk_branches)) + 1;
reg_base = of_iomap(np, 0);
if (!reg_base) {
pr_err("%s: could not map cru region\n", __func__);
return ERR_PTR(-ENOMEM);
}
ctx = rockchip_clk_init(np, reg_base, CLK_NR_CLKS);
ctx = rockchip_clk_init(np, reg_base, max(common_nr_clks, soc_nr_clks));
if (IS_ERR(ctx)) {
pr_err("%s: rockchip clk init failed\n", __func__);
iounmap(reg_base);
@ -608,8 +614,12 @@ static struct rockchip_clk_provider *__init rk3128_common_clk_init(struct device
static void __init rk3126_clk_init(struct device_node *np)
{
struct rockchip_clk_provider *ctx;
unsigned long soc_nr_clks;
ctx = rk3128_common_clk_init(np);
soc_nr_clks = rockchip_clk_find_max_clk_id(rk3126_clk_branches,
ARRAY_SIZE(rk3126_clk_branches)) + 1;
ctx = rk3128_common_clk_init(np, soc_nr_clks);
if (IS_ERR(ctx))
return;
@ -626,8 +636,12 @@ CLK_OF_DECLARE(rk3126_cru, "rockchip,rk3126-cru", rk3126_clk_init);
static void __init rk3128_clk_init(struct device_node *np)
{
struct rockchip_clk_provider *ctx;
unsigned long soc_nr_clks;
ctx = rk3128_common_clk_init(np);
soc_nr_clks = rockchip_clk_find_max_clk_id(rk3128_clk_branches,
ARRAY_SIZE(rk3128_clk_branches)) + 1;
ctx = rk3128_common_clk_init(np, soc_nr_clks);
if (IS_ERR(ctx))
return;

18
drivers/clk/rockchip/clk-rk3188.c
View File

@ -757,9 +757,11 @@ static const char *const rk3188_critical_clocks[] __initconst = {
"sclk_mac_lbtest",
};
static struct rockchip_clk_provider *__init rk3188_common_clk_init(struct device_node *np)
static struct rockchip_clk_provider *__init rk3188_common_clk_init(struct device_node *np,
unsigned long soc_nr_clks)
{
struct rockchip_clk_provider *ctx;
unsigned long common_nr_clks;
void __iomem *reg_base;
reg_base = of_iomap(np, 0);
@ -768,7 +770,9 @@ static struct rockchip_clk_provider *__init rk3188_common_clk_init(struct device
return ERR_PTR(-ENOMEM);
}
ctx = rockchip_clk_init(np, reg_base, CLK_NR_CLKS);
common_nr_clks = rockchip_clk_find_max_clk_id(common_clk_branches,
ARRAY_SIZE(common_clk_branches)) + 1;
ctx = rockchip_clk_init(np, reg_base, max(common_nr_clks, soc_nr_clks));
if (IS_ERR(ctx)) {
pr_err("%s: rockchip clk init failed\n", __func__);
iounmap(reg_base);
@ -789,8 +793,11 @@ static struct rockchip_clk_provider *__init rk3188_common_clk_init(struct device
static void __init rk3066a_clk_init(struct device_node *np)
{
struct rockchip_clk_provider *ctx;
unsigned long soc_nr_clks;
ctx = rk3188_common_clk_init(np);
soc_nr_clks = rockchip_clk_find_max_clk_id(rk3066a_clk_branches,
ARRAY_SIZE(rk3066a_clk_branches)) + 1;
ctx = rk3188_common_clk_init(np, soc_nr_clks);
if (IS_ERR(ctx))
return;
@ -812,11 +819,14 @@ CLK_OF_DECLARE(rk3066a_cru, "rockchip,rk3066a-cru", rk3066a_clk_init);
static void __init rk3188a_clk_init(struct device_node *np)
{
struct rockchip_clk_provider *ctx;
unsigned long soc_nr_clks;
struct clk *clk1, *clk2;
unsigned long rate;
int ret;
ctx = rk3188_common_clk_init(np);
soc_nr_clks = rockchip_clk_find_max_clk_id(rk3188_clk_branches,
ARRAY_SIZE(rk3188_clk_branches)) + 1;
ctx = rk3188_common_clk_init(np, soc_nr_clks);
if (IS_ERR(ctx))
return;

4
include/dt-bindings/clock/rk3128-cru.h
View File

@ -116,6 +116,7 @@
#define PCLK_GMAC 367
#define PCLK_PMU_PRE 368
#define PCLK_SIM_CARD 369
#define PCLK_MIPIPHY 370
/* hclk gates */
#define HCLK_SPDIF 440
@ -143,8 +144,7 @@
#define HCLK_TSP 475
#define HCLK_CRYPTO 476
#define HCLK_PERI 478
#define CLK_NR_CLKS (HCLK_PERI + 1)
#define HCLK_SFC 479
/* soft-reset indices */
#define SRST_CORE0_PO 0

2
include/dt-bindings/clock/rk3188-cru-common.h
View File

@ -132,8 +132,6 @@
#define HCLK_VDPU 472
#define HCLK_HDMI 473
#define CLK_NR_CLKS (HCLK_HDMI + 1)
/* soft-reset indices */
#define SRST_MCORE 2
#define SRST_CORE0 3