TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: venus: avoid multiple core dumps

Browse Source 
Core dump is generated whenever there is system error reported
by firmware. Right now, multiple such dumps are generated if
recovery fails in first attempt, since the sys error handler is
invoked again for every failed recovery.
To avoid it, add conditional check to generate core dump only
once during every system error notification from firmware.

Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Stanimir Varbanov <stanimir.k.varbanov@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil: document new dump_core field]
This commit is contained in:
Dikshita Agarwal 2024-03-06 11:23:26 +05:30 committed by Hans Verkuil
parent e750a4b122
commit 02e92ea83b
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/platform/qcom/venus/core.c
View File

@ -68,6 +68,7 @@ static void venus_event_notify(struct venus_core *core, u32 event)
mutex_lock(&core->lock);
set_bit(0, &core->sys_error);
set_bit(0, &core->dump_core);
list_for_each_entry(inst, &core->instances, list)
inst->ops->event_notify(inst, EVT_SESSION_ERROR, NULL);
mutex_unlock(&core->lock);
@ -110,7 +111,10 @@ static void venus_sys_error_handler(struct work_struct *work)
venus_shutdown(core);
venus_coredump(core);
if (test_bit(0, &core->dump_core)) {
venus_coredump(core);
clear_bit(0, &core->dump_core);
}
pm_runtime_put_sync(core->dev);

2
drivers/media/platform/qcom/venus/core.h
View File

@ -169,6 +169,7 @@ struct venus_format {
* @core1_usage_count: usage counter for core1
* @root: debugfs root directory
* @venus_ver: the venus firmware version
* @dump_core: a flag indicating that a core dump is required
*/
struct venus_core {
void __iomem *base;
@ -232,6 +233,7 @@ struct venus_core {
u32 minor;
u32 rev;
} venus_ver;
unsigned long dump_core;
};
struct vdec_controls {